open_social icon indicating copy to clipboard operation
open_social copied to clipboard

Issue #3302921 by chmez: Support visibility tooltip for any entity type

Open OH17L opened this issue 2 years ago • 2 comments

Problem

The "Visibility" field has a tooltip only for groups and nodes.

Solution

Extend functionality which manages the visibility field to cover all entity types.

Issue tracker

  • https://www.drupal.org/project/social/issues/3302921
  • https://getopensocial.atlassian.net/browse/PROD-19356

How to test

  • [ ] Declare "hook_social_group_content_visibility_field" hook in your module which should return "field_media_visibility".
  • [ ] Repeat the first three steps from PR #2947.
  • [ ] You should see a question sign after the label of the “Visibility” field.

Release notes

Support visibility tooltip for any entity type.

Change Record

https://www.drupal.org/node/3303876

OH17L avatar Aug 10 '22 16:08 OH17L

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. :blush:

mergeable[bot] avatar Aug 10 '22 16:08 mergeable[bot]

Tugboat has finished building the preview for this pull request!

Link:

  • https://pr3069-ez3yw9tc1xublbvln1szysfph6mmtxnn.tugboatqa.com

Dashboard:

  • https://dashboard.tugboatqa.com/62f3d73219770b441a6e7ba8

open-social-tugboat avatar Aug 16 '22 11:08 open-social-tugboat

PHPStan checks require your attention.

navneet0693 avatar Oct 22 '22 04:10 navneet0693

Hi @navneet0693, Now it's ready for the review again.

ribel avatar Nov 10 '22 09:11 ribel

🍒 -picked to 11.5.x

ribel avatar Nov 25 '22 07:11 ribel