Issue #3294898 by zanvidmar: Add dashboard link (Google analytics)

[zanvidmar]

Issue #3294898 by zanvidmar: Add dashboard link (Google analytics) for OS > 11.1

Problem

In Open Social 11.1.0 a feature dashboard has been introduced where shortcuts can be made. https://github.com/goalgorilla/open_social/pull/2764

Distro introduced the dashboard, this conflicted with the dashboard of the social_saas_core and it was removed. https://bitbucket.org/goalgorilla/social_saas_core/pull-requests/44

As Google analytics was also removed by social_saas_core pull request 44 we need to add Google analytics back there.

Solution

Add the Google analytics link to the dashboard via new social_user_engagement module. The new module and it's name has been discussed with @tbsiqueira already (although description was not so there is still room for improvement).

Issue tracker

3294898

PROD-1318 PROD-12697 PROD-12688

Theme issue tracker

N/A

How to test

• [ ] Open dashboard
• [ ] The expected result is to see Google Analytics link under "Configuration"

Definition of done

Before merge

• [ ] Code/peer review is completed
• [ ] All commit messages are clear and clean. If applicable a rebase was performed
• [ ] All automated tests are green
• [ ] Functional/manual tests of the acceptance criteria are approved
• [ ] All acceptance criteria were met
• [ ] New features or changes to existing features are covered by tests, either unit (preferably) or behat
• [ ] Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• [ ] Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• [ ] This pull request has all required labels (team/type/priority)
• [ ] This pull request has a milestone
• [ ] This pull request has an assignee (if applicable)
• [ ] Any front end changes are tested on all major browsers
• [ ] New UI elements, or changes on UI elements are approved by the design team
• [ ] New features, or feature changes are approved by the product owner

After merge

• [ ] Code is tested on all branches that it has been cherry-picked
• [ ] Update hook number might need adjustment, make sure they have the correct order
• [ ] The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N/A

Release notes

New social_user_engagement has been introduced to cover anything related with tracking. Right now it holds just a dashboard menu item for Google analytics.

Change Record

[Required if applicable] If this Pull Request changes the way that developers should do things or introduces a new API for developers then a change record to document this is needed. Please provide a draft for a change record or a link to an unpublished change record below. Existing change records can be consulted as example. Please provide a draft for a change record or a link to an unpublished change record below. Existing change records can be consulted as example.

Translations

If we are not translating the module name / description then no, otherwise yes:

• 'Social User Engagement'
• 'Provides user engagement components.'

[mergeable[bot]]

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. :blush:

[robertragas]

Sorry, I approved a bit too early. After functional testing I saw that enabling this module won't work as it's missing the dependency to google_analytics so should be added to the composer.json

But was it agreed with @tbsiqueira that google analytics will be added to the core? Because I know we are fighters for privacy, and Google Analytics doesn't has the best reputation there. I think it should be a dedicated repository.

[tbsiqueira]

@zanvidmar , I closed this PR since we don't have plans to add google analytics to core as a required module. Please feel free to reopen it if necessary