open_social icon indicating copy to clipboard operation
open_social copied to clipboard

Published 20 hours ago • verified publisher icon goalgorilla

Updates: (deps): Update drupal/core-composer-scaffold requirement from ~9.3.15 to ~9.4.5

Open dependabot[bot] opened this issue 2 years ago • 7 comments

Updates the requirements on drupal/core-composer-scaffold to permit the latest version.

Commits
  • 5f37a9e Issue #3283498 by Mile23, alexpott: Scaffold ReplaceOp::copyScaffold() throws...
  • 3286dbf Issue #3088730 by Spokje, anmolgoyal74, ankithashetty, Mile23, longwave, nare...
  • 8539fd0 Issue #3219649 by quietone, murilohp, longwave: Fix spelling for words used o...
  • 1844eec Issue #3207567 by Spokje, quietone, guilhermevp, yogeshmpawar, daffie, alexpo...
  • 8746004 Issue #3222769 by bbrala, alexpott, longwave, Matroskeen: [November 8, 2021] ...
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot[bot] avatar Jul 07 '22 23:07 dependabot[bot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot] avatar Jul 12 '22 13:07 dependabot[bot]

A newer version of drupal/core-composer-scaffold exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot[bot] avatar Jul 20 '22 23:07 dependabot[bot]

This PR requires: https://github.com/goalgorilla/drupal_social/pull/378

navneet0693 avatar Jul 25 '22 07:07 navneet0693

We need to rework on the following:

"Post update hook naming convention patch": "https://git.drupalcode.org/project/drupal/-/merge_requests/1215.patch"

navneet0693 avatar Jul 25 '22 07:07 navneet0693

Pending work: Check for installation failure, because of missing use Drupal\Core\Session\AccountInterface; statement in system.module in hook_entity_field_access()

navneet0693 avatar Jul 27 '22 03:07 navneet0693

For adding PHP 8.1 support, we need to work on https://www.drupal.org/node/3268032#core

navneet0693 avatar Aug 01 '22 07:08 navneet0693

Tugboat has finished building the preview for this pull request!

Link:

  • https://pr3028-vkrrz3d1gqs0o13puufn9xodvl7opwgl.tugboatqa.com

Dashboard:

  • https://dashboard.tugboatqa.com/62d7a250d082cde9bc3a36e3

open-social-tugboat avatar Aug 17 '22 11:08 open-social-tugboat

This is resolved https://github.com/goalgorilla/open_social/pull/3028#issuecomment-1200836393

We need to work on resolving conflicts with Bootstrap, we will need an upgraded version of https://www.drupal.org/project/bootstrap, https://www.drupal.org/project/socialbase and https://www.drupal.org/project/socialblue

navneet0693 avatar Sep 01 '22 12:09 navneet0693

I did a QA test (using the spreadsheet that has over 300 scenarios), here is my feedback:

  1. On 'All members' page (/all-members), the introduction text is not correctly HTML escaped, also the field title is displayed. All members | Open Social 2022-10-03 09-59-59

  2. The crop field is not displaying correctly (on all node edit pages), I also had some issues with image displays but this could be related to my local setup.

Edit Book page dccdsc | Open Social 2022-10-03 10-29-13

  1. The details element(when nested) in every form has a different display and its kinda hard to notice it, this may not be a bug, but just adding it here just in case. Create an event | Open Social 2022-10-03 10-36-19

  2. The social_dashboard module has an empty 'Settings' details element(on /node/add/dashboard), this should be hidden if empty. Create a dashboard | Open Social 🔊 2022-10-05 11-13-41

  3. The social_discussion module breaks on install, the error (may be related to the module itself and not the 9.4 upgrade) open-social-dev ddev site:admin:modules:list:confi

  4. In the social_questions_answers module, when trying to preview the answer, you get WSOD (may be related to module and not the 9.4 update) euoeu | Open Social 2022-10-06 10-55-04

  5. When logged in as administrator, you get a lot of 'Edit' icons and some of them are placed in not the best place, eq: Home | Open Social 🔊 2022-10-06 11-00-47

nkoporec avatar Oct 06 '22 09:10 nkoporec

New PR: https://github.com/goalgorilla/open_social/pull/3148

navneet0693 avatar Oct 10 '22 09:10 navneet0693