examples icon indicating copy to clipboard operation
examples copied to clipboard

Note to streaming examples

Open ghoben opened this issue 4 years ago • 2 comments

Thanks for making those good examples to see how something is working. I tried to work with the streaming example chatter/chatter-cli and I was wondering in the beginning, why the client app did not work as described in the Readme. It took me some time to find the correct branch which had the chatter-cli implemented the functionality which is described.

In order for new people it would be easier if the master version of "chatter-cli.go" has the code of the branch: "testing_poc" included to have a working example out of the box.

I would be happy to prepare the changes to outsource the working on the stream into a new file in the package main which shows how to deal with the streams, if that's ok?

ghoben avatar Feb 19 '21 21:02 ghoben

Well I recreated goa before I checked the chatter-cli.go which recreated the chatter-cli.go and removed all the changes which are checked in. It took me a while to recognize this. Maybe it would be better to move the chatter-cli changes into a separate file so that they are not gone in case you trapped in the same problem as I did :). Again thanks for the examples.

ghoben avatar Feb 20 '21 09:02 ghoben

Hello, thank you for raising the issue! the master branch should absolutely work out-of-the-box and I'd happily merge a PR that fixed it. I think what might have happened is that the Makefile at the top got changed to delete the content of the chatter-cli directory instead of skipping it like it skips other examples cli directory that have custom code, in other words this line: https://github.com/goadesign/examples/blob/master/Makefile#L186 should be altered so it doesn't delete chatter-cli. I'll make a note to fix this but if you get to it first then include that in the PR as well, thank you!

raphael avatar Feb 23 '21 22:02 raphael