xivlauncher-neo icon indicating copy to clipboard operation
xivlauncher-neo copied to clipboard

Credential storage

Open goaaats opened this issue 2 years ago • 4 comments

We should probably do this for ourself as a crate, with implementations for:

  • [ ] Windows Credential Manager
  • [ ] OS X Keychain
  • [ ] Gnome Keyring

goaaats avatar Nov 15 '21 02:11 goaaats

Are we planning fully-native apps? If not, macOS and Linux could still default to using the Windows Credential Manager as Wine manages that fine.

reiichi001 avatar Nov 15 '21 03:11 reiichi001

I don't know how the UNIX keyrings work, but for Windows per earlier discussions, I have karashiiro/wincredentials-rs done as an MVP.

karashiiro avatar Nov 15 '21 16:11 karashiiro

This exists for Linux https://github.com/mathstuf/rust-keyutils, if we're willing to use a small out-of-network library. I can't find anything for macOS.

karashiiro avatar Nov 18 '21 22:11 karashiiro

Nevermind, this covers all of our needs: https://github.com/hwchen/keyring-rs For some reason I was only able to find this here, I wasn't able to find it through any of my previous searches :thinking:

karashiiro avatar Nov 18 '21 22:11 karashiiro