frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Bug: Filtering Lists

Open mtettke123 opened this issue 2 years ago • 10 comments

Using the "filter" button in list view, I can filter "assignees" (small bug: When selecting a person, you can see the selected person a couple of millisecons, then the field is empty again, but the filter works).

Using the "new saved filter" setting in namespaces/lists, filtering with an assignee always returns an empty list.

Small workflow improvement: it would be great if filters in list view could be saved ("save this filter").

mtettke123 avatar Aug 04 '22 12:08 mtettke123

Can you reproduce this on try?

kolaente avatar Aug 04 '22 13:08 kolaente

Well, surprinsingly no. Filtering works here (but I'm using unstable, shouldn't this be the same?). The small bug (selecting a person that disappears is strange in try, too: Selecting "demo" as user yields to: grafik

mtettke123 avatar Aug 04 '22 13:08 mtettke123

Well, surprinsingly no. Filtering works here

Then it's probably already fixed in unstable.

but I'm using unstable, shouldn't this be the same?

It should, when did you last upgrade?

The small bug (selecting a person that disappears is strange in try, too: Selecting "demo" as user yields to:

That sounds like another bug. I'll take a look.

kolaente avatar Aug 04 '22 15:08 kolaente

Filtering seems to be solved. Just updated. works.

The small bug is still there (in my installation: selected person disappers like if no one is selected, but filter works)...

mtettke123 avatar Aug 05 '22 12:08 mtettke123

I confirm Person disappears immediatly after selection in Assignees But filter can be created and is working

glungtung avatar Aug 13 '22 07:08 glungtung

The cause of this problem is a little complicated and has two parts.

In the frontend, the bug occurs because the filter value changes after a user was selected. This triggers a rebuild of all filter values which for the assignee filter means a search request to get the full name etc of the user. BUT the assignee filter only stores user ids and the user search endpoint does not handle those (to prevent usernames leaking by just increasing the id). Therefore, the search returns no results and the user disappears. The filter component does this to show the correct values if the filter changed from the outside (aka was just loaded). This can be fixed with a check if there's already data loaded and not loading it if that's the case. Still not ideal because then it won't update if the filter is changed from the outside again after loading it but we're not doing that at the moment.

The other problem is the mentioned filter search: Because we can't lookup user IDs we should ideally save usernames. They are unique and relatively un-guessable (no enumeration possible). If we save usernames instead of IDs we'll need to change the filter logic so that it is able to search by username instead of ID. Possible. but a breaking change.

kolaente avatar Aug 15 '22 18:08 kolaente

Filtering by asignee works great in list view but not in kanban, it always returns an empty list.

ToniMurcia avatar Aug 29 '22 07:08 ToniMurcia

Filtering by asignee works great in list view but not in kanban, it always returns an empty list.

Filters are not supported for kanban right now.

kolaente avatar Sep 01 '22 12:09 kolaente

Do you mean "Filters are not supported for kanban" only for assignee field? Because the rest of fields work great when filtering in kanban view: labels, priority, progress, etc.

ToniMurcia avatar Sep 02 '22 08:09 ToniMurcia

I mean you can't filter by Kanban buckets or view a saved filter in Kanban view.

kolaente avatar Sep 02 '22 09:09 kolaente