server icon indicating copy to clipboard operation
server copied to clipboard

enhance(build): return build on CreateBuild and UpdateBuild

Open ecrupper opened this issue 2 years ago • 1 comments

Part of the effort for https://github.com/go-vela/community/issues/613. It would be helpful to not have to make two calls to the database during our webhook process. This can be remedied by returning the created build object when it's saved to the database.

ecrupper avatar Sep 22 '22 19:09 ecrupper

Codecov Report

Merging #701 (bfdcac6) into main (71240b4) will decrease coverage by 2.99%. The diff coverage is 42.10%.

:exclamation: Current head bfdcac6 differs from pull request most recent head 38bd752. Consider uploading reports for the commit 38bd752 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
- Coverage   58.08%   55.10%   -2.99%     
==========================================
  Files         255      201      -54     
  Lines       15876    15972      +96     
==========================================
- Hits         9222     8801     -421     
- Misses       6249     6789     +540     
+ Partials      405      382      -23     
Impacted Files Coverage Δ
api/build.go 1.65% <0.00%> (+0.17%) :arrow_up:
api/webhook.go 0.00% <0.00%> (ø)
database/postgres/build.go 91.17% <50.00%> (-4.69%) :arrow_down:
database/sqlite/build.go 91.17% <50.00%> (-4.69%) :arrow_down:

... and 149 files with indirect coverage changes

codecov[bot] avatar Sep 22 '22 19:09 codecov[bot]

closing because this has become a mess. Will just use a new branch

ecrupper avatar Jun 13 '23 15:06 ecrupper