community icon indicating copy to clipboard operation
community copied to clipboard

deployment notice unaware of updated repo state

Open wass3rw3rk opened this issue 1 year ago • 0 comments

Description

This notice when adding a deployment is nice, but doesn't remove itself once deployment:created event is enabled.

image

to reproduce:

  1. enable repo
  2. go to deployments page to add a deployment
  3. you will see the above notice
  4. navigate to repo settings
  5. enable deployment:created event
  6. return to add a deployment form
  7. notice is still shown even though it is incorrect now

expected:

notice should disappear once the event is enabled

i would propose the following tweaks:

  1. rephrase to something like "To trigger builds for deployments, enable a 'Deployment' event on the Settings page for this repo." (or something similar)
  2. make deployments aware of updated repo state

Value

reduce confusion/friction; better ux when adding a deployment via ui

Useful Information

  1. What is the output of vela --version?

v0.23.0-rc

  1. What operating system is being used?
  1. Any other important details?

wass3rw3rk avatar Feb 02 '24 16:02 wass3rw3rk