community icon indicating copy to clipboard operation
community copied to clipboard

feat(proposal): Build init `Log` instead of magic "init" `Step`

Open cognifloyd opened this issue 1 year ago • 8 comments

Key Value
Author(s) @cognifloyd
Reviewers @jbrockopp, @plyr4
Date April 21st, 2023
Status Reviewed

Status:

  • [x] Reviewed (Reviewers added to the proposal)
  • [ ] Approved (Status updated in proposal and proposal merged)
  • [ ] Implemented
    • [ ] Types
    • [ ] Server
    • [ ] sdk-go
    • [ ] CLI
    • [ ] Worker
      • [ ] Build log to new endpoints and deprecate magic "init" string (in one release)
      • [ ] Remove special casing around magic "init" string (in another release)
    • [ ] UI

This is a successor to:

  • https://github.com/go-vela/community/pull/771

cognifloyd avatar Apr 21 '23 20:04 cognifloyd

Target team revisited this proposal during our biweekly review. The team needs more time to dig into the details. Look for more conversations and feedback in the upcoming week.

chrispdriscoll avatar May 10 '23 14:05 chrispdriscoll

I need someone familiar eith elm to handle the UI.

I can help out with this. I think it would be great to organize build init separately from step logs so that its more obvious to the user. spitballing ideas, but perhaps we build an Init tab (akin to Services), or a collapsible <details> element that is attached to the BuildPreview block?

ideally whatever solution we go with should be backwards compatible, and i'd prefer to have old and new builds look similar to avoid confusion. i can mock up some ideas

plyr4 avatar May 16 '23 18:05 plyr4

@cognifloyd We're laying out the upcoming roadmap and wanted to take this into consideration. It's been a little time since we last discussed. Is this still something you want? If so, maybe recap where we're at.

chrispdriscoll avatar Jul 20 '23 16:07 chrispdriscoll

@cognifloyd We haven't heard anything on this and are rapidly approaching the v0.21 release. We'll move you to v0.22 for October. Please let us know if you think October is doable and/or if you want this pushed out further.

chrispdriscoll avatar Aug 30 '23 14:08 chrispdriscoll

@cognifloyd Just posting an update during our monthly review of public PRs. During our last Committers Sync you mentioned other top priorities so this didn't have your attention. We're tentatively looking at an early November release for 0.22 so let us know if you think this might fit in that release. If not, we always have 0.23.

chrispdriscoll avatar Oct 11 '23 14:10 chrispdriscoll

@cognifloyd With v0.22 rc1 available, the next opportunity for this enhancement will be v0.23 (January 2024). Please let us know if we should expect these updates in that release.

chrispdriscoll avatar Nov 08 '23 14:11 chrispdriscoll

Probably not. Still digging through a backlog of things I need to do.

cognifloyd avatar Nov 09 '23 01:11 cognifloyd

@cognifloyd It's been a couple months. Is this still a feature you're working on? If so, maybe share an updated timeline for when we should expect to see an update.

chrispdriscoll avatar Apr 10 '24 14:04 chrispdriscoll