community
community copied to clipboard
go-vela
Display timestamp of log lines
Description
Users are currently unable to determine how long each command takes within any given step without printing timestamps themselves. Adding some sort of timestamp to the given log lines would help alleviate this frustration.
Value
- Users are able to troubleshoot which command(s) are taking the majority of build time
- Users are able to determine when command(s) were ran
Definition of Done
- Users are able to view log line timestamps within the UI and API
Effort (Optional)
Impacted Personas (Optional)
Should this be configurable? ie should you be able to hide/show the timestamps in the UI?
Or should the timestamps just always be present?
For the kubernetes runtime, I need to flip one boolean flag to start including timestamps, but then they will always be included: https://github.com/go-vela/worker/blob/69101f70dbf7f2714757673a56b35afef5c1d097/runtime/kubernetes/container.go#L247
opts := &v1.PodLogOptions{
Container: ctn.ID,
Follow: true,
- Timestamps: false,
+ Timestamps: true,
}
working on some design mockups for this issue
what do you think of this? @JordanSussman
im thinking about placement and purpose, the font color is temporary.
