task icon indicating copy to clipboard operation
task copied to clipboard

Docs are not correct sources and status can co-exist

Open ghostsquad opened this issue 3 years ago • 3 comments
trafficstars

Docs indicate that status overrides/precedes sources. But #477 says otherwise.

https://taskfile.dev/changelog/#v360---2021-07-10

ghostsquad avatar Jun 26 '22 20:06 ghostsquad

Hi @ghostsquad,

They can coexist. Look at this code:

https://github.com/go-task/task/blob/e36c77aaf3ed88be1583868288958bb272534fa0/status.go#L31-L61

If both checks are available, both need to pass for the task to be run.

If you think something is not working correctly, can you attach an example Taskfile that shows the issue?

andreynering avatar Jul 06 '22 13:07 andreynering

@andreynering I'm pointing out that the docs don't reflect that these can co-exist. The docs need to be updated

ghostsquad avatar Jul 06 '22 16:07 ghostsquad

@ghostsquad Can you submit a PR?

andreynering avatar Aug 04 '22 02:08 andreynering