slim-sprig icon indicating copy to clipboard operation
slim-sprig copied to clipboard

Published 20 hours ago • verified publisher icon go-task

Adding submatch (capture group) support.

Open chris-garrett opened this issue 4 years ago • 2 comments

Hiya,

I have a PR up on the original repo to add capture group support (submatch) to strings. The function is called: regexFindSubmatch. I would love to see this in task if that is possible. I'm not sure what the process is for doing that. Should I also PR against this repo?

PR on masterminds is here:

https://github.com/Masterminds/sprig/pull/298

A second branch which is up to date with this repo is here:

https://github.com/chris-garrett/slim-sprig/tree/add-find-submatches

Let me know what you think Andrey.

Thanks!

chris-garrett avatar May 01 '21 23:05 chris-garrett

Hi @chris-garrett,

Once the PR is merged upstream just let me know so I can update this repo with upstream to automatically have that.

I woudn't add it here first, because if it happens to go to upstream with a different name or signature (for example), then we'll have a problem (at least it would be inconsistent).

andreynering avatar May 05 '21 12:05 andreynering

sounds good ty.

chris-garrett avatar May 08 '21 01:05 chris-garrett