mysql icon indicating copy to clipboard operation
mysql copied to clipboard

Revert double buffering.

Open methane opened this issue 1 year ago • 1 comments

Go 1.21 will fix race between Context cancel and sql.RawBytes. See https://github.com/golang/go/issues/60304

It will be backported to Go 1.19.

We had implemented double buffering (#943) to workaround it. It increase memory usage and complexity.

After Go 1.19.10 containing this fix is released, let's remove the double buffering in go-mysql-driver v1.8.0.

P.S. We need to drop Go 1.18 support. It would violate our Go version support policy. But Go 1.21 will be released in August, before we release v1.8.0.

methane avatar May 24 '23 08:05 methane

It is not backported into Go 1.19 and 1.20. So we need to wait that we drop Go 1.20 support.

methane avatar Oct 09 '23 09:10 methane