Cannot unset "Make archive publicly available" once it has been saved with true

[ishults]

Data

• 1.5.5:
• MariaDb:
• Ubuntu 22.04:
• Docker Compose:

Describe the bug / actual behavior

If you check "Make archive publicly available" and then go back and uncheck it, the unchecked value (public = false) does not save, and the link remains public.

Expected behavior

A clear and concise description of what you expected to happen.

To Reproduce

0. (Not sure if this step is critical) - Go to settings and ensure "Make archive publicly available by default" is unchecked
1. Select any existing archive and check "Make archive publicly available"
2. Click "OK"
3. In another browser/session, visit the public URL and ensure you can view the page.
4. Go back to your admin session and uncheck "Make archive publicly available" for that website.
5. Refresh the page.
6. Edit the archive again and notice that "Make archive publicly available" is still checked.
7. In another browser/session, note that you can still visit the URL.

Screenshots

Notes

It looks like the UI is still sending "public: "1"" to the API even when the box is unchecked. I wonder if there's a falsey-check failing somewhere.

[fmartingr]

After investigating this a bit, this may be caused by the asynchronous way we handle the archives, if we change the bookmark in a quick succession after adding it this line will overwrite changes with the values we used when we first added it.