shiori
shiori copied to clipboard
go-shiori
PWA + offline
I know this project seems to be abandoned. But contributing on the off chance that you pick it up. Based on #296 but this makes it work fully disconnected and caches some bookmarks for offline viewing making it more pocket like and useful
Looks like we are back in business. You might want to take a look again. New maintainer!
Ah fantastic! Hopefully things pick back up. So far just this change has made it very useful to. Just pin to Home Screen on mobile and can read even with no internet connection :)
I am just seeing this now--@geekgonecrazy evidently knows more about PWA caching than I do, but I will try to work on the web share target component which was my original aim (offline was just a bonus) and submit that as a separate PR
Hey @geekgonecrazy 👋 are you still working on this PR? If not I can take a look and make the updates suggested by @fmartingr
@karlprieb hey my friend! Fancy seeing you here :) I haven't had time to mess with this for a while. I'll add you as contributor on my fork if you want to make more changes.
Hey @geekgonecrazy, @karlprieb, is this something you are still interested on working on?
This issue has been automatically marked as stale because it has not had any activity for quite some time. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey @fmartingr I’m still interested in working on this feature, sadly I’m not having the necessary time to do so :(
Hey @karlprieb, no problem, I will just keep this open then. We all have our things in life :)
Any updates about the progress? I think this feature is a game changer for the project.
I started working on PWA separate from this pull request and have a working PWA profile and share target but not offline caching. I would be open to reworking my patches with this PR and finish this feature.
I started working on PWA separate from this pull request and have a working PWA profile and share target but not offline caching. I would be open to reworking my patches with this PR and finish this feature.
Please feel free to take what is done here and wrap into own PR 🙏
No ETA, but I have an MVP working locally in the iOS simulator. Up to the publishing bit now.
Could it also be used directly from the browser by adding it to home screen/applications without the need of installing an app from the store?
Good point! Looks like the offline bit will need more testing.
PWA portion works pretty well, but the viewport needs adjusting for newer phones without a home button.
I'll keep at it 🤙
From: Felipe Martin @.> Sent: Tuesday, July 4, 2023 5:22:10 AM To: go-shiori/shiori @.> Cc: pythoninthegrass @.>; Manual @.> Subject: Re: [go-shiori/shiori] PWA + offline (PR #325)
No ETA, but I have an MVP workinghttps://github.com/go-shiori/shiori/compare/master...pythoninthegrass:shiori:shiori-mobile locally in the iOS simulator. Up to the publishing bithttps://docs.pwabuilder.com/#/builder/app-store?id=publishing now.
Could it also be used directly from the browser by adding it to home screen/applications without the need of installing an app from the store?
— Reply to this email directly, view it on GitHubhttps://github.com/go-shiori/shiori/pull/325#issuecomment-1619973775, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA7ILP3WON3RSV77TBSSPJLXOPVFFANCNFSM5NEX5UHQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>
@fmartingr @pythoninthegrass Hi there, thanks for all the contribution and discussion! PWA would bring Shiori to next level to fully replace other bookmark managers (especially the default bookmark managers from Chrome and Safari). May I know if this PR is still active? If so, any context of the current blocker preventing it from being merged? Thanks.
@fmartingr @pythoninthegrass Hi there, thanks for all the contribution and discussion! PWA would bring Shiori to next level to fully replace other bookmark managers (especially the default bookmark managers from Chrome and Safari). May I know if this PR is still active? If so, any context of the current blocker preventing it from being merged? Thanks.
I can't say myself, there are some people interested in moving this forward but sadly since we do this in our free time I guess is difficult to just sit down and go on with it. I also think this would be a game changer but I'm not that into frontend development (if I were, I would refactor all of it 😂 )
@fmartingr hit the nail on the head. I made some progress but with the latest API changes, it became too much of a lift.
I'm pretty green at go and frontend isn't my strong suit. My fork is still available and the manifest.json (manifest.webmanifest) is about 2/3 complete according to pwabuilder.
Ended up migrating to Omnivore and while it doesn't quite check all the boxes, it suits my needs and has very responsive devs who are actively implementing features I'm interested in.
@fmartingr hit the nail on the head. I made some progress but with the latest API changes, it became too much of a lift.
I'm pretty green at go and frontend isn't my strong suit. My fork is still available and the manifest.json (manifest.webmanifest) is about 2/3 complete according to pwabuilder.
Ended up migrating to Omnivore and while it doesn't quite check all the boxes, it suits my needs and has very responsive devs who are actively implementing features I'm interested in.
That's sad to hear, but understandable :)
I may hop on to the task then, while I make the changes to the API. Thanks for putting your time into it anyway, really appreciated.
You're welcome! It was a good learning experience and appreciate what you've done to make a viable pocket alternative ☺️
From: Felipe Martin @.> Sent: Sunday, September 10, 2023 2:21:41 AM To: go-shiori/shiori @.> Cc: pythoninthegrass @.>; Mention @.> Subject: Re: [go-shiori/shiori] PWA + offline (PR #325)
@fmartingrhttps://github.com/fmartingr hit the nail on the head. I made some progress but with the latest API changes, it became too much of a lift.
I'm pretty green at go and frontend isn't my strong suit. My fork is still available and the manifest.json (manifest.webmanifest) is about 2/3 complete according to pwabuilderhttps://www.pwabuilder.com/.
Ended up migrating to Omnivore and while it doesn't quite check all the boxes, it suits my needs and has very responsive devs who are actively implementing features I'm interested in.
That's sad to hear, but understandable :)
I may hop on to the task then, while I make the changes to the API. Thanks for putting your time into it anyway, really appreciated.
— Reply to this email directly, view it on GitHubhttps://github.com/go-shiori/shiori/pull/325#issuecomment-1712737618, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA7ILP5VFYRAFI7PYCBZ5BDXZVTALANCNFSM5NEX5UHQ. You are receiving this because you were mentioned.Message ID: @.***>
Any helper needed ? I wanted to make a simple pwa of shiori just to be able to share links to it, but apparently some work was done here ? I can checkout this branch and try to fix
