rod icon indicating copy to clipboard operation
rod copied to clipboard

chore: update `fetchup` and `got`

Open secustor opened this issue 8 months ago • 4 comments

This PR updates github.com/ysmood/fetchup and github.com/ysmood/got to the newest version.

As visible in the first commit it bumped the version in go and adapted to changed APIs in fetchup

Development guide

Link

Test on local before making the PR

go run ./lib/utils/simple-check

The simple check script fails for changes outside of this PR so I could not run it outside of the full context. That being said I can try to fix them, I have some local changes to fix most surface problems.

secustor avatar Jun 23 '25 14:06 secustor

I noticed this also and found @secustor already submitted a PR. Thank you very much :) Pinning to the older github.com/ysmood/fetchup v0.3.0 until your PR is merged into a new release.

craig-stone-hpe avatar Jul 17 '25 07:07 craig-stone-hpe

Since the new version of fetchup has been adapted, why not merge it?

ilovesusu avatar Aug 05 '25 10:08 ilovesusu

@ysmood, could you look into merging this please? It's a pain to keep downgrading fetchup to v0.3.0 every time after go get -u ./... because [email protected] still uses the old signature call.

rusq avatar Aug 10 '25 04:08 rusq

why this, never merge?

ryanbekhen avatar Sep 13 '25 23:09 ryanbekhen

Review required At least 1 approving review is required by reviewers with write access.

Yet,

Fly-Playgroud removed the request for review from ysmood 4 months ago

Hmm.. do the above mean that @ysmood can merge it now, or there need yet another reviewer?

suntong avatar Dec 18 '25 02:12 suntong