resty icon indicating copy to clipboard operation
resty copied to clipboard

Save time Last-Modified to output file

Open gonejack opened this issue 4 years ago • 1 comments

Hi,

This PR saves header time "last-modified" to output file.

gonejack avatar Nov 17 '21 05:11 gonejack

Codecov Report

Merging #493 (c830781) into master (313f419) will decrease coverage by 0.45%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   96.69%   96.24%   -0.45%     
==========================================
  Files          10       10              
  Lines        1330     1333       +3     
==========================================
- Hits         1286     1283       -3     
- Misses         26       31       +5     
- Partials       18       19       +1     
Impacted Files Coverage Δ
middleware.go 92.22% <33.33%> (-0.64%) :arrow_down:
request.go 96.35% <0.00%> (-1.46%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 19 '22 23:07 codecov[bot]

@gonejack I'm sorry for the delayed attention on the PR. Can you please add test coverage for this PR? See here - https://github.com/go-resty/resty/pull/493/checks?check_run_id=11777873655

Once ready we can merge this PR!

jeevatkm avatar Mar 05 '23 23:03 jeevatkm

@jeevatkm Yes, but need some time, since this PR is made by 2021.

gonejack avatar Mar 06 '23 03:03 gonejack

@gonejack Thanks for your contribution. I thought about this PR, I think we should make this as opt-in option to use last modified date from the response header. I will take up this later on. For now I'm closing this one.

jeevatkm avatar Mar 19 '23 22:03 jeevatkm