py.RunFile / RunCode doesn't handle a nil module pointer

[SolarLune]

Hey, there. It's really cool to be able to run Python in Go! I'd like to congratulate you on this project, it might be exactly what I've been looking for when it comes to an easily embeddable scripting language.

I just noticed that py.RunFile() and py.RunCode() don't handle a nil py.Module pointer when deciding to create a new module. I feel like that would lessen the friction on using it, since if you run multiple files and want them to be in a single module you currently have to call two different RunFile() / RunCode() calls that are essentially the same (just with nil as the inModule argument the first time).

Basically, currently I'm doing this:

var mod *py.Module

...

// In a for loop for mutliple .py files

if mod == nil {
	mod, err = py.RunFile(context, fpath, py.CompileOpts{UseSysPaths: true}, nil) // Returns a new module
} else {
	mod, err = py.RunFile(context, fpath, py.CompileOpts{UseSysPaths: true}, mod) // Adds onto the existing one
}

and it would be easier to just do this:

var mod *py.Module

...

mod, err = py.RunFile(context, fpath, py.CompileOpts{UseSysPaths: true}, mod) // Returns a new module on first run because 'mod' is nil, adds onto the existing module afterwards

I believe to implement this I would just need to modify RunCode() to check for nil in the case *Module part of the inModule type check. Does this sound OK?

[ncw]

Your before and after seem to be the same so I'm not sure I understand!

if mod == nil {
	mod, err = py.RunFile(context, fpath, py.CompileOpts{UseSysPaths: true}, nil) // Returns a new module
} else {
	mod, err = py.RunFile(context, fpath, py.CompileOpts{UseSysPaths: true}, mod) // Adds onto the existing one
}

Is exactly the same as this isn't it as mod will be nil on first run.

mod, err = py.RunFile(context, fpath, py.CompileOpts{UseSysPaths: true}, mod) // Returns a new module on first run because 'mod' is nil, adds onto the existing module afterwards

[SolarLune]

Hello - the difference is that I'd like to not call py.RunFile twice, just once. Unless I'm misunderstanding, I have to call it twice currently because passing nil in as an argument to create a new module isn't the same as passing a nil pointer to a *py.Module, as this part of RunCode() switches off of the argument type explicitly:

https://github.com/go-python/gpython/blob/e20a7a44caad86725015a2a3c756197b05c8ae34/py/run.go#L154

So running it with nil for inModule creates a new module, and running it with a pointer to a module for py.Module will update the module, but passing a nil py.Module pointer will cause a crash.