gpython icon indicating copy to clipboard operation
gpython copied to clipboard

[WIP] Implement dict to receive Object as key

Open HyeockJinKim opened this issue 6 years ago • 2 comments

Implement dict struct that takes Object as key store key and value in array together so that dict is ordered

Issue #118

HyeockJinKim avatar Oct 19 '19 13:10 HyeockJinKim

Codecov Report

Merging #119 into master will decrease coverage by 0.65%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #119      +/-   ##
=========================================
- Coverage   72.85%   72.2%   -0.66%     
=========================================
  Files          60      60              
  Lines       11949   12057     +108     
=========================================
  Hits         8706    8706              
- Misses       2709    2815     +106     
- Partials      534     536       +2
Impacted Files Coverage Δ
py/dict.go 36.65% <0%> (-35.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c23b14...9e2f6ab. Read the comment docs.

codecov-io avatar Oct 19 '19 13:10 codecov-io

Since Hash is not implemented properly in gpython, I'm going to implement a dict that takes an Object as a key first.

So, even if an object representing the same value comes in as key, the value is not found correctly.

This can break the test code, so instead of getting rid of StringDict, I will fully implement Dict and replace StringDict with Dict.

HyeockJinKim avatar Oct 19 '19 13:10 HyeockJinKim