gopy icon indicating copy to clipboard operation
gopy copied to clipboard

[Draft] Support for multiple return values from go function to python

Open nishantsharma opened this issue 3 years ago • 8 comments

Support for multiple return values from go function to python

nishantsharma avatar Jun 15 '22 13:06 nishantsharma

Some memory leaks exist.

nishantsharma avatar Jun 19 '22 08:06 nishantsharma

Yeah, would it make sense to delete this PR for the time being and rebase on the variadic version which I will test now. The variadic one does not have any leaks?

rcoreilly avatar Jun 19 '22 08:06 rcoreilly

you can resubmit a PR once you have it working with out leaks I mean.

rcoreilly avatar Jun 19 '22 08:06 rcoreilly

Sure. Variadic shouldn't have leaks. I may take up fixing of memory leaks later as per internal priority.

nishantsharma avatar Jun 19 '22 08:06 nishantsharma

Actually, it may still make sense to review from the perspective of behavior. Esp. translating error return into exceptions. Also, deleting PRs causes context to be lost. Will suggest making it a draft PR.

nishantsharma avatar Jun 19 '22 08:06 nishantsharma

ok.. I'll try to take a look in a few days. Meanwhile in the future, please run your code through gofmt -- that check is failing on test.

rcoreilly avatar Jun 19 '22 08:06 rcoreilly

ps. thanks for submitting these fixes -- much appreciated!

rcoreilly avatar Jun 19 '22 08:06 rcoreilly

URL changes are temporary. Made them to test. Will revert before switching PR draft status. JFYI.

nishantsharma avatar Jul 04 '22 01:07 nishantsharma