webhooks icon indicating copy to clipboard operation
webhooks copied to clipboard

Add Chinese code platform gitee webhooks

Open li-clement opened this issue 2 years ago • 6 comments

li-clement avatar Apr 18 '22 11:04 li-clement

Coverage Status

Coverage decreased (-1.2%) to 87.04% when pulling 2755e3cb78f22cd75c727f3a66f14673c1e290fe on robekeane:gitee into 9c954e23a1b901399c0f9d71645f84d3287641ca on go-playground:master.

coveralls avatar Apr 18 '22 11:04 coveralls

It seems to be a lint-tool issue

li-clement avatar Apr 18 '22 11:04 li-clement

It seems to be a lint-tool issue

It should be good to investigate it. May be run linter locally. Are you sure, that linter pass successful?

Toshik1978 avatar Apr 18 '22 15:04 Toshik1978

The lint tool shows this, I don't know if there's something wrong with it. I test all the code on my own server, all the check items are pass.

level=error msg="Running error: buildir: failed to load package goarch: could not load export data: cannot import \"internal/goarch\" (unknown iexport format version 2), export data is newer version - update tool"

li-clement avatar Apr 22 '22 08:04 li-clement

The lint tool shows this, I don't know if there's something wrong with it.

I'm a little bit busy right now, but will be able to investigate it in 1-2 weeks. Can you try, pls, the following: update linter version to the latest one (1.45.2). It's here: https://github.com/go-playground/webhooks/blob/master/.github/workflows/workflow.yml#L19

Toshik1978 avatar Apr 24 '22 21:04 Toshik1978

The lint tool shows this, I don't know if there's something wrong with it.

I'm a little bit busy right now, but will be able to investigate it in 1-2 weeks. Can you try, pls, the following: update linter version to the latest one (1.45.2). It's here: https://github.com/go-playground/webhooks/blob/master/.github/workflows/workflow.yml#L19

@Toshik1978 Thanks for remind me that. I will try to fix it.

li-clement avatar Apr 25 '22 01:04 li-clement