validator icon indicating copy to clipboard operation
validator copied to clipboard

enhancement: add id translations for some tag

Open gunturvo opened this issue 4 years ago • 2 comments

Details

  • add e164, unique, json, jwt, lowercase, uppercase, datetime, postcode_iso3166_alpha2, postcode_iso3166_alpha2_field
  • update ip4_addr, ip6_addr, unix_addr
  • remove some empty line to match with en.go (make it easier to compare for future translation)
  • update the unit test

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • [x] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

gunturvo avatar Aug 12 '21 11:08 gunturvo

Coverage Status

Coverage decreased (-0.1%) to 74.992% when pulling c68c41e42895a2291693e9bb406eeadcfb558a96 on gunturvo:update-id into ce34f361cca51e25715399ab801c5e1c01d02d89 on go-playground:master.

coveralls avatar Aug 12 '21 11:08 coveralls

@gunturvo sorry it's taken this long to get to your PR.

I looks like the tests are failing, is there any way you could take a look a it?

deankarn avatar May 01 '22 15:05 deankarn