validator icon indicating copy to clipboard operation
validator copied to clipboard
verified publisher icon go-playground

Update workflow.yml to support 2 most recent major versions

Open nodivbyzero opened this issue 8 months ago • 5 comments

Fixes Or Enhances

Based on the https://github.com/go-playground/validator?tab=readme-ov-file#maintenance-and-support-for-sdk-major-versions

Make sure that you've checked the boxes below before you submit PR:

  • [ ] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

nodivbyzero avatar Apr 16 '25 19:04 nodivbyzero

Coverage Status

coverage: 73.655% (+0.002%) from 73.653% when pulling bb82cbd6abff203bc7eaad7d5ba368108810dbfd on nodivbyzero:github-action-support-2-major-go-versions into 8032f400f4942bd2376b759570abab3dfcb73bbb on go-playground:master.

coveralls avatar Apr 16 '25 19:04 coveralls

@deankarn @zemzale Can you please review this PR? This change is required to address high-severity vulnerabilities in golang.org/x/crypto.

nodivbyzero avatar Apr 17 '25 17:04 nodivbyzero

We only officially support the latest two versions, but is there any reason to not test the older version as well until if starts failing?

deankarn avatar Apr 30 '25 09:04 deankarn

@deankarn I'm just trying to understand the reasoning - why test the older version if it's no longer officially supported? Are we planning to address any breaking issues if tests start failing on that version?

nodivbyzero avatar Apr 30 '25 15:04 nodivbyzero

@deankarn I've added a new workflow that triggers on pushes to the master branch and runs tests using Go versions 1.21 through 1.24. bb82cbd6abff203bc7eaad7d5ba368108810dbfd

nodivbyzero avatar May 08 '25 15:05 nodivbyzero

@deankarn @zemzale Whenever you get a chance, could you please review this PR?

nodivbyzero avatar Jun 25 '25 19:06 nodivbyzero