validator icon indicating copy to clipboard operation
validator copied to clipboard
verified publisher icon go-playground

feat: add validation for weekends

Open putrafajarh opened this issue 10 months ago • 4 comments

Fixes Or Enhances

Added new validation rules weekend

Make sure that you've checked the boxes below before you submit PR:

  • [x] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

putrafajarh avatar Feb 17 '25 00:02 putrafajarh

Coverage Status

coverage: 74.368% (+0.02%) from 74.348% when pulling ab2e3573e76fedd9ef87d940d7f26de7d8146ed0 on putrafajarh:master into 02409170a8b58d92ee6f4ae5fa2889b9adef5bf0 on go-playground:master.

coveralls avatar Feb 17 '25 00:02 coveralls

Just want to know, if my PR approve, is it better to add another rule weekday ? @deankarn @nodivbyzero

putrafajarh avatar Feb 17 '25 12:02 putrafajarh

Thanks for your contribution!

Interesting idea, but the implementation seems limited to a specific date format. Would it still work if the date format is 'January 25, 2025 15:04' or 'Jan 25, 2025'?

nodivbyzero avatar Feb 17 '25 20:02 nodivbyzero

@nodivbyzero it utilize time.Parse, it should work.

The problem is according to doc, need to put 0x2C to represent comma

putrafajarh avatar Feb 18 '25 12:02 putrafajarh