kratos icon indicating copy to clipboard operation
kratos copied to clipboard

#3110 bugfix instead throw errors when too much err happend not to cover errors

Open SchopenhauerZhang opened this issue 1 year ago • 3 comments

https://github.com/go-kratos/kratos/issues/3110

when too much errors happened ,print history err; 如果发生过error,就把发生过的error一并返回;而不是通过重复赋值将error =nil进行掩盖。

SchopenhauerZhang avatar Dec 08 '23 06:12 SchopenhauerZhang

CR,Please,THX -:)

SchopenhauerZhang avatar Dec 08 '23 06:12 SchopenhauerZhang

CR,Please,THX -:)

SchopenhauerZhang avatar Dec 08 '23 06:12 SchopenhauerZhang

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (69268c5) 84.37% compared to head (bddd731) 84.05%. Report is 1 commits behind head on main.

:exclamation: Current head bddd731 differs from pull request most recent head 64865cf. Consider uploading reports for the commit 64865cf to get more accurate results

Files Patch % Lines
app.go 20.00% 4 Missing and 4 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3111      +/-   ##
==========================================
- Coverage   84.37%   84.05%   -0.32%     
==========================================
  Files          88       88              
  Lines        3988     3996       +8     
==========================================
- Hits         3365     3359       -6     
- Misses        447      455       +8     
- Partials      176      182       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 11 '23 03:12 codecov-commenter