kratos icon indicating copy to clipboard operation
kratos copied to clipboard

feat:add http client do With middleware #2228

Open wang-tsh opened this issue 2 years ago • 5 comments

Description (what this PR does / why we need it): #2228 add a new method named DoWithMiddleware

Which issue(s) this PR fixes (resolves / be part of): #2228

Other special notes for the reviewers:

wang-tsh avatar Aug 29 '22 02:08 wang-tsh

Codecov Report

Merging #2324 (8c2e469) into main (b339ae8) will decrease coverage by 0.35%. The diff coverage is 71.42%.

:exclamation: Current head 8c2e469 differs from pull request most recent head 7098b8d. Consider uploading reports for the commit 7098b8d to get more accurate results

@@            Coverage Diff             @@
##             main    #2324      +/-   ##
==========================================
- Coverage   85.23%   84.87%   -0.36%     
==========================================
  Files          88       88              
  Lines        3826     3809      -17     
==========================================
- Hits         3261     3233      -28     
- Misses        391      405      +14     
+ Partials      174      171       -3     
Impacted Files Coverage Δ
transport/http/client.go 84.05% <71.42%> (-1.43%) :arrow_down:
encoding/form/proto_decode.go 53.74% <0.00%> (-8.04%) :arrow_down:
config/reader.go 80.61% <0.00%> (-0.39%) :arrow_down:
selector/node/ewma/node.go 86.81% <0.00%> (-0.15%) :arrow_down:
config/value.go 47.41% <0.00%> (-0.09%) :arrow_down:
options.go 100.00% <0.00%> (ø)
log/level.go 100.00% <0.00%> (ø)
config/config.go 54.66% <0.00%> (ø)
encoding/form/form.go 65.71% <0.00%> (ø)
log/filter.go 95.55% <0.00%> (+0.31%) :arrow_up:
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 01 '22 00:09 codecov-commenter

please fix lint

shenqidebaozi avatar Nov 10 '22 03:11 shenqidebaozi

这个问题已经过去半年多了,有大佬们跟进吗

suncle1993 avatar Apr 11 '23 08:04 suncle1993

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


It has been more than half a year since this problem, has anyone followed up?

kratos-ci-bot avatar Apr 11 '23 08:04 kratos-ci-bot

Any updates? It will be helpful to send custom request as well as using middlewares implementing kratos.Middleware

NeoyeElf avatar Apr 13 '24 07:04 NeoyeElf