kratos icon indicating copy to clipboard operation
kratos copied to clipboard

the wg.Done in app.New() doesn't seem to work [Question]

Open rhythmszn1011 opened this issue 2 years ago • 1 comments

image even delete the wg,The service still starts normally,so what is the point of wg.

rhythmszn1011 avatar Aug 10 '22 09:08 rhythmszn1011

Right, because it's synchronous, I haven't thought of a good way.

tonybase avatar Aug 13 '22 05:08 tonybase

Hi, @rhythmszn1011! I'm Dosu, and I'm here to help the kratos team manage their backlog. I wanted to let you know that we are marking this issue as stale.

Based on my understanding, the issue you raised is about the wg.Done function in app.New() not functioning as intended. It seems that even when the wg variable is removed, the service still starts normally, which has caused confusion about the purpose of wg. Tonybase commented that they haven't found a good solution yet as the function is synchronous.

Before we proceed, we would like to confirm if this issue is still relevant to the latest version of the kratos repository. If it is, please let us know by commenting on this issue. Otherwise, feel free to close the issue yourself, or the issue will be automatically closed in 7 days.

Thank you for your contribution, and we appreciate your understanding as we work to manage and prioritize the repository's issues. If you have any further questions or concerns, please don't hesitate to let us know.

dosubot[bot] avatar Nov 02 '23 16:11 dosubot[bot]