kratos icon indicating copy to clipboard operation
kratos copied to clipboard

Global logger

Open realityone opened this issue 1 year ago • 1 comments

Description (what this PR does / why we need it):

Global GetLogger return the inner Logger in global logger appliance, this will make inconsistent logger after SetLogger is called.

Return global logger appliance directly to wrap the inner logger, always make the all logger is same from GetLogger.

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

realityone avatar Aug 10 '22 06:08 realityone

Codecov Report

Merging #2265 (10dc850) into main (57dee51) will decrease coverage by 0.05%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2265      +/-   ##
==========================================
- Coverage   85.63%   85.57%   -0.06%     
==========================================
  Files          87       87              
  Lines        3793     3793              
==========================================
- Hits         3248     3246       -2     
- Misses        378      380       +2     
  Partials      167      167              
Impacted Files Coverage Δ
log/global.go 77.55% <66.66%> (-4.09%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 10 '22 07:08 codecov-commenter

func (a *loggerAppliance) Log(level Level, keyvals ...interface{}) error {
	return a.Logger.Log(level, keyvals...)
}

This increases the call depth of global logger.

SeniorPlayer avatar Aug 12 '22 07:08 SeniorPlayer