kit icon indicating copy to clipboard operation
kit copied to clipboard

Published 20 hours ago • verified publisher icon go-kit

SD - Registrator error handling

Open jstoja opened this issue 5 years ago • 1 comments

Is there any reason for not returning any error on the registration of a service? https://github.com/go-kit/kit/blob/ec0cc13a9b00d1214c9b7ae63d7b750626b54c6d/sd/registrar.go#L11

From my point of view, if a service doesn't manage to correctly register, then it might be nice to retry later. Binding to events to watch if you're correctly registered seems overkilled compared to just checking this error.

What are your thoughts?

jstoja avatar Oct 23 '18 10:10 jstoja

Sure, happy to take a PR with a fix. Be sure to fix all implementations of Registrar :)

peterbourgon avatar Oct 23 '18 16:10 peterbourgon