kit icon indicating copy to clipboard operation
kit copied to clipboard

Tracing support for thrift

Open mqliang opened this issue 7 years ago • 2 comments

Is it possible to add tracing support for Thrift ?

mqliang avatar Feb 23 '18 04:02 mqliang

This would involve mirroring the Server and Client types, as in the other transport packages, and providing the relevant hooks, e.g. ServerBefore, ServerAfter, etc. Certainly possible.

peterbourgon avatar Feb 23 '18 06:02 peterbourgon

Thrift has no concept of metadata/headers so you'll need to envelope your messages and have some way of figuring out if a message was enveloped or not. If only producing and consuming services under your wings this is obviously not difficult as you control the message payload, but in a polyglot environment you'll need to see what the already established patterns are. I suggest looking at finagle which has dealt with this exact issue.

basvanbeek avatar Feb 23 '18 09:02 basvanbeek