kit icon indicating copy to clipboard operation
kit copied to clipboard
verified publisher icon go-kit

Fixed EncodeJSONResponse body writing

Open kerma opened this issue 1 year ago • 4 comments

EncodeJSONResponse is not writing body for status codes 100-199, 204, 304 according to https://datatracker.ietf.org/doc/html/rfc7230#section-3.3

Fixes #1291

kerma avatar Jul 10 '24 13:07 kerma

Eh, that RFC is more of a suggestion than a requirement :)

peterbourgon avatar Jul 10 '24 13:07 peterbourgon

@peterbourgon I'm a bit confused. I reported #1291 a while ago. In the response there you hinted that this should be fixed, as the EncodeJSONResponse is broken when the user implements a response with a 304 StatusCode.

Should I include just the 304 for that fix, or why you closed this one exactly?

kerma avatar Jul 11 '24 09:07 kerma

Huh, me too apparently.

peterbourgon avatar Jul 11 '24 15:07 peterbourgon

@peterbourgon anything for me to do here? I guess the CI / Build issues are unrelated to this PR.

kerma avatar Sep 03 '24 20:09 kerma