router icon indicating copy to clipboard operation
router copied to clipboard

Don't include fragment identifier when matching.

Open jancona opened this issue 7 years ago • 1 comments

I ran into problems with fragment ids causing URLs not to match and it seemed odd to match on them, given the the server doesn't normally see them.

jancona avatar Jul 07 '17 19:07 jancona

@jancona can you provide some more context on the problems you were running into? go-humble/router is designed to fallback to using fragment ids whenever history.pushState is not supported. I'm hesitant to accept this change without understanding why it is necessary and how it might affect behavior in older browsers that do not support history.pushState.

albrow avatar Dec 14 '17 00:12 albrow