graphite-clickhouse icon indicating copy to clipboard operation
graphite-clickhouse copied to clipboard

Published 20 hours ago • verified publisher icon go-graphite

Upgrade prometheus

Open Felixoid opened this issue 3 years ago • 7 comments

Here's a branch with the updated vendor path https://github.com/lomik/graphite-clickhouse/tree/upgrade_prometheus

Felixoid avatar Oct 14 '20 11:10 Felixoid

Hi, how working is the branch? I would like to update since there is an assumption that some promql queries do not work because of this.

ihard avatar Mar 18 '21 15:03 ihard

Hey. I have zero experience in Prom, so can't provide any support on the topic. I am not sure why has removed help wanted, since help is definitely needed here

Felixoid avatar Mar 18 '21 17:03 Felixoid

I upgraded the branch https://github.com/lomik/graphite-clickhouse/tree/upgrade_prometheus and there some initial attempts to adjust the code to the latest prom. But since I am not in the context of Prometheus, I am not sure what should be next.

As far as I see, the current prometheus.Querier must be split into two different types, Querier and ChunkQuerier. If one would take care of it, I'll for sure spend time to review it

Felixoid avatar May 10 '21 22:05 Felixoid

As you can connect a normal prometheus as remote reader - I'm wondering if its needed to have a prometheus integrated. Providing the remote storage endpoint and running a prometheus instance should be enough? or am I missing something?

bzed avatar May 25 '21 10:05 bzed

GCH has a feature to provide graphite metrics in the native prometheus format. See https://github.com/lomik/graphite-clickhouse/blob/master/prometheus/querier_select.go#L33, for example

Felixoid avatar May 25 '21 11:05 Felixoid

Ah sorry, I've missed that / is being routed into prometheus. I thought that the remote read/write interface was different code.

bzed avatar May 25 '21 11:05 bzed