Confirm behavior in Cache

Open yunstanford opened this issue 7 years ago • 3 comments

Is there any strong reason to have the confirm behavior in Cache while updating whisper ?

Does it just handle failed whisper updates ? It does a lot linear searches and moves in notConfirmed there. just curious if there is a strong motivation for that.

Apr 02 '18 01:04 yunstanford

Also, I didn't see any handle around failed confirmed points, looks like just appending to notConfirmed and keeping it there. feel free to point it out if i'm missing anyting

Apr 02 '18 02:04 yunstanford

notConfirmed used for store points after remove from main cache and before save to whisper file. and for access to them via carbonlink

the removal of points is in the method Cache.Confirm

Apr 24 '18 19:04 lomik

maybe this is not best solution. you found this in the cpu profile?

Apr 24 '18 19:04 lomik