carbonapi icon indicating copy to clipboard operation
carbonapi copied to clipboard

Docker image for 0.15.4 missing?

Open deniszh opened this issue 3 years ago • 6 comments

Discussed in https://github.com/go-graphite/carbonapi/discussions/654

Originally posted by spoofedpacket November 9, 2021 The docker image for 0.15.4 seems to be missing:

https://hub.docker.com/r/gographite/carbonapi/tags

$ docker pull gographite/carbonapi:v0.15.4
Error response from daemon: manifest for gographite/carbonapi:v0.15.4 not found: manifest unknown: manifest unknown
```</div>

deniszh avatar Nov 09 '21 14:11 deniszh

We should migrate build to Github Actions (and maybe Github Docker repos) because Docker removed autobuilds.

deniszh avatar Nov 17 '21 08:11 deniszh

It is still missing, do you need help migrating to Github Actions?

akamensky avatar May 13 '22 05:05 akamensky

@akamensky : it's done - https://github.com/go-graphite/carbonapi/tree/main/.github/workflows but we had no releases after implementing this. You can't trigger push actions retroactively IIRC. If you know how to do so - let me know. Or we can cut 0.15.5 maybe, @Civil ?

deniszh avatar May 13 '22 07:05 deniszh

PS: but docker upload failed when I implemented that for go-carbon, so, I removed that workflow from it, keep only ghcr.io. So, I suspecting same will happen with carbonapi. Docker became really unfriendly to free usage after acquisition, so, probably we should switch to ghcr.io here too.

deniszh avatar May 13 '22 07:05 deniszh

I'd like to ensure that everything in caronapi works and tested on Go 1.18 and after that I'll cut a new release.

Civil avatar May 13 '22 22:05 Civil

I put the docker workflow on pause (I completely forgot about it when I was tagging 0.15.5 version to be honest) and I'll remove it completely in near future.

Civil avatar May 23 '22 11:05 Civil

Current release v0.15.6 and image still missing from ghcr.io.

akamensky avatar Nov 29 '22 03:11 akamensky

I'm hoping to tag 0.16 in near future (once #742 is merged and once I finish changelog, as we are over 200 commits since last release and there were a lot of important changes), I hope 0.16 should get a docker image. Unfortunately I'm not sure it's worth running it for 0.15.6 at this moment.

However if you notice any problems in github workflows, PRs or suggestions/comments are always welcome.

Civil avatar Dec 04 '22 22:12 Civil

Forgot to mention, but docker workflow is defined here: https://github.com/go-graphite/carbonapi/blob/main/.github/workflows/docker-ghcrio.yml

Civil avatar Dec 04 '22 22:12 Civil

Ok... something is definitely wrong with the conditions for workflow and I have no idea what is that.

I'll try to debug that in separate repos and will try to push a fix in next couple of days.

Civil avatar Dec 08 '22 21:12 Civil

0.16.0-patch1 should be uploaded to the ghcr.io (thx to @deniszh for finding the last problem that caused failure).

I think from now on process should be reliable enough.

Civil avatar Dec 09 '22 10:12 Civil