carbonapi icon indicating copy to clipboard operation
carbonapi copied to clipboard

Published 20 hours ago • verified publisher icon go-graphite

Choose server method for a cluster without that metric returns the entire list of servers

Open gksinghjsr opened this issue 6 years ago • 1 comments

The chooseServer method for a cluster returns the entire list of servers by default if it finds a metric not present in any server of that cluster. This was fine previously, when zipper had one big cluster, but now that we have a config with multi cluster support, this is a problem, and will result in many more requests to backends for metrics it won't find.

https://github.com/go-graphite/carbonapi/blob/0cbfd1dec9bec44daf03debccd23d5ca12557de8/zipper/broadcast/broadcast_group.go#L82

gksinghjsr avatar Jul 05 '18 12:07 gksinghjsr

I think this would be "fixed" (would work good enough) after proposal from #423 would be implemented.

Civil avatar Jul 17 '20 22:07 Civil