gorm icon indicating copy to clipboard operation
gorm copied to clipboard

feature(finisher_api): add Exists method

Open demoManito opened this issue 1 year ago • 1 comments

  • [x] Do only one thing
  • [x] Non breaking API changes
  • [x] Tested

What did this pull request do?

User Case Description

demoManito avatar Sep 30 '24 10:09 demoManito

Hi, can I add this method? If so, is it reasonable to add it this way, or should it be placed in the driver? @jinzhu

demoManito avatar Oct 10 '24 09:10 demoManito

Maybe we should place it in a helper package, keeping GORM itself clean and avoiding adding too much API directly.

jinzhu avatar Nov 14 '24 09:11 jinzhu

Maybe we should place it in a helper package, keeping GORM itself clean and avoiding adding too much API directly.

Do you mean the helper package under the go-gorm organization? @jinzhu

demoManito avatar Nov 14 '24 10:11 demoManito

For now, we probably won’t maintain an additional helper package. It could be placed in a separate third-party library for the time being.

jinzhu avatar Nov 14 '24 10:11 jinzhu

For now, we probably won’t maintain an additional helper package. It could be placed in a separate third-party library for the time being.

ok

demoManito avatar Nov 14 '24 11:11 demoManito