gitea icon indicating copy to clipboard operation
gitea copied to clipboard

Avatar not visisble in pr commit history rows

Open stuzer05 opened this issue 10 months ago • 10 comments

Description

Avatar not set enymore in pr history

Image but when clicking on commit hash -avatar is there Image

Gitea Version

1.24.0+dev-306-g70327d6a92

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

None

stuzer05 avatar Feb 14 '25 09:02 stuzer05

The email that is used for the commits in the PR could be different from the one used by the system when merging/squashing the PR. Could you verify that the emails are the same, and if not, then that the email for the commits is added to your profile.

techknowlogick avatar Feb 14 '25 14:02 techknowlogick

Email is the same, and gitea finds it, in explore page history

Image

but in pr history it doesn't

Image

also, when chicking on commit - avatar is there, as it should be. Only pr history is broken

Image

stuzer05 avatar Feb 14 '25 15:02 stuzer05

Caused by #33528. I will send a PR to fix it.

lunny avatar Feb 14 '25 22:02 lunny

I sent #33602 to fix this, please review.

lunny avatar Feb 15 '25 00:02 lunny

@stuzer05 ah, my apologies. Thanks for those additional details:)

techknowlogick avatar Feb 15 '25 00:02 techknowlogick

Not fixed in 1.24.0+dev-321-gf35850f48e

stuzer05 avatar Feb 17 '25 08:02 stuzer05

Not fixed in 1.24.0+dev-321-gf35850f48e

Can you confirm the user doesn't hide his email?

lunny avatar Feb 17 '25 08:02 lunny

Email is private. But avatar is only missing in pr commit history. Elsewhere in commit history (repo, explore page, when viewing commit) - avatar visible

stuzer05 avatar Feb 17 '25 08:02 stuzer05

Email is private. But avatar is only missing in pr commit history. Elsewhere in commit history (repo, explore page, when viewing commit) - avatar visible

I will take a look at it.

lunny avatar Feb 19 '25 07:02 lunny

Looks like #34643 fixed this issue. @stuzer05 please help to confirm.

lunny avatar Jun 10 '25 03:06 lunny

@stuzer05 this issue unlocked

lunny avatar Jun 10 '25 15:06 lunny

Fix confirmed

stuzer05 avatar Jun 10 '25 15:06 stuzer05