Avatar not visisble in pr commit history rows
Description
Avatar not set enymore in pr history
but when clicking on commit hash -avatar is there
Gitea Version
1.24.0+dev-306-g70327d6a92
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
docker
Database
None
The email that is used for the commits in the PR could be different from the one used by the system when merging/squashing the PR. Could you verify that the emails are the same, and if not, then that the email for the commits is added to your profile.
Email is the same, and gitea finds it, in explore page history
but in pr history it doesn't
also, when chicking on commit - avatar is there, as it should be. Only pr history is broken
Caused by #33528. I will send a PR to fix it.
I sent #33602 to fix this, please review.
@stuzer05 ah, my apologies. Thanks for those additional details:)
Not fixed in 1.24.0+dev-321-gf35850f48e
Not fixed in 1.24.0+dev-321-gf35850f48e
Can you confirm the user doesn't hide his email?
Email is private. But avatar is only missing in pr commit history. Elsewhere in commit history (repo, explore page, when viewing commit) - avatar visible
Email is private. But avatar is only missing in pr commit history. Elsewhere in commit history (repo, explore page, when viewing commit) - avatar visible
I will take a look at it.
Looks like #34643 fixed this issue. @stuzer05 please help to confirm.
@stuzer05 this issue unlocked
Fix confirmed