Timeline avatars of code comments on pull request page doesn't not align vertically.

Open lunny opened this issue 1 year ago • 2 comments

https://gitea.com/gitea/helm-chart/pulls/596

May 09 '24 07:05 lunny

@wxiaoguang I tried to revert #29935, then it works well. So I think it is caused by #29935. Maybe we should not add timeline-avatar-offset class in this case

May 24 '24 04:05 yp05327

Before 29935, see #29934, I do not think 29935 is directly related. 29935 is written to fix the bug described by #29934

Maybe it needs more code to check different cases.

May 24 '24 06:05 wxiaoguang

~~I'm confusing which is right. And why reviews should have timeline-avatar-offset. It seems that it comes from https://github.com/go-gitea/gitea/pull/24526/files#r1188069927~~

It is used for this case?

In github:

Maybe adjust the direction of "speech bubble" is much easier than adding these complex conditions.

Sep 12 '24 02:09 yp05327