gitea icon indicating copy to clipboard operation
gitea copied to clipboard
verified publisher icon go-gitea

Code review comment line number problem.

Open lunny opened this issue 1 year ago • 4 comments

When comment on a previous commit of a pull request, the comment is in line number 39

image

But after two new commits pushed, the comment haven't been marked as outdated or hidden. The line number is still line 39 but now it should be line 58.

image

lunny avatar May 03 '24 03:05 lunny

Can you provide the URL of these screenshots.

yp05327 avatar May 07 '24 00:05 yp05327

https://gitea.com/gitea/blog/pulls/367/files

lunny avatar May 07 '24 01:05 lunny

related to #21113 ?

metiftikci avatar May 23 '24 23:05 metiftikci

Maybe different because there is no force push on https://gitea.com/gitea/blog/pulls/367/files

lunny avatar May 24 '24 01:05 lunny

I am also experiencing this issue

skarndev avatar Jun 07 '24 08:06 skarndev

This is because line is hard coded in DB, and this should be calculated dynamically.

So I think we need to consider a new flag (or generate from existing fields) to record the line.

yp05327 avatar Jun 10 '24 00:06 yp05327