gitea icon indicating copy to clipboard operation
gitea copied to clipboard
verified publisher icon go-gitea

Refactor the function `CanMaintainerWriteToBranch`

Open lunny opened this issue 1 year ago • 5 comments

This PR does some refactors.

  • [x] Removed function GetFirstUnitRepoID() to match the comment
  • [x] Add a headRepoID parameter to CanMaintainerWriteToBranch to replace removed GetFirstUnitRepoID() and rename it to CanUserWriteToBranch

lunny avatar Apr 29 '24 09:04 lunny

Bug fix or pure-refactoring?

wxiaoguang avatar May 02 '24 14:05 wxiaoguang

Bug fix or pure-refactoring?

pure-refactoring.

lunny avatar May 02 '24 14:05 lunny

Then defer it until 1.22 gets a stable release?

wxiaoguang avatar May 02 '24 14:05 wxiaoguang

And one more thing, any test?

wxiaoguang avatar May 02 '24 14:05 wxiaoguang

Then defer it until 1.22 gets a stable release?

1.22.0 has been released

delvh avatar Jun 07 '24 19:06 delvh