gitea icon indicating copy to clipboard operation
gitea copied to clipboard

Move repo setting menu to right side to keep consistent with org's

Open lunny opened this issue 1 year ago • 2 comments

Before

图片

After

图片

For mobile, it's the same as before. 图片

lunny avatar Jan 29 '24 15:01 lunny

It bleeds into the fade-out effect at the end of the tab bar, which is imho unacceptable.

We should replace this fade out effect with a GitHub-like mechanism that moves overflowing tab bar elements into a ... button, but that will require some JS to work. With that, Settings can only stay left-aligned.

silverwind avatar Jan 29 '24 17:01 silverwind

Have to check how it looks on mobile...

I have checked it works. See the updated screenshots.

lunny avatar Feb 02 '24 09:02 lunny

But now organization's settings are already aligned to the right. This PR will keep them both consistent.

lunny avatar Feb 25 '24 05:02 lunny

Have to check how it looks on mobile...

Mobile screenshots updated. It's not affected.

lunny avatar Feb 25 '24 05:02 lunny

It does affect desktop where the "s" in "Settings" is faded out as well as the line below. Thise fade-out is not present on org page. Imho it looks to bad and I have to block it.

silverwind avatar Feb 25 '24 10:02 silverwind

Removing the fade-out on this new-menu might be one way to solve it that is borderline acceptable to me. A better way would be to implement a tab bar that overflows into a menu like this, ideally using a web component to prevent loading flash.

silverwind avatar Feb 25 '24 10:02 silverwind

I will have a try at implementing such an overflow menu. Won't be a web component at least, though.

silverwind avatar Feb 25 '24 11:02 silverwind

Depends on https://github.com/go-gitea/gitea/pull/29400 and I will implement the moving of the settings menu in it I think.

silverwind avatar Feb 25 '24 16:02 silverwind