gitea icon indicating copy to clipboard operation
gitea copied to clipboard

Redirect after merge pull commit isn't working

Open somera opened this issue 1 year ago • 14 comments

Description

When I mere a pull requests

image

the redirect isn't working. In Chrome I see only this

image

in 1.21.3 it worked. I was redirected to the result page.

Gitea Version

1.21.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.43.0

Operating System

Ubuntu 22.04.3 LTS x86_64

How are you running Gitea?

Downloaded gitea-1.21.4-linux-amd64

Database

PostgreSQL

somera avatar Jan 17 '24 08:01 somera

Same problem with FF.

somera avatar Jan 17 '24 13:01 somera

Do you have JS enabled?

delvh avatar Jan 17 '24 13:01 delvh

Yes. Cause and I didn't change nothing between the update from 1.21.3 to 1.21.4. My last pull merge with 1.21.3 was ~10 days ago without any issues. And after the update to 1.21.4 I see only the redirect json in Chrome and FF.

somera avatar Jan 17 '24 14:01 somera

The merge is working. But the redirect after isn't -> something changes here.

somera avatar Jan 17 '24 14:01 somera

Sounds like #28140 iintroduced a regression then…

delvh avatar Jan 17 '24 14:01 delvh

What happens if you clear your browser cache? Does the issue persist then?

delvh avatar Jan 17 '24 14:01 delvh

What happens if you clear your browser cache? Does the issue persist then?

Isn't working. I use gitea only with chrome. And for testing I cleared browser cache too.

I used FF only to check the issue. Cause I don't use FF for gitea.

Can you reproduce this issue on your gitea instance?

somera avatar Jan 17 '24 14:01 somera

Sounds like #28140 iintroduced a regression then…

Maybe related with https://github.com/go-gitea/gitea/pull/28140/files#r1399519508

lunny avatar Jan 17 '24 14:01 lunny

@lunny will be this fixed in 1.21.5?

somera avatar Jan 18 '24 11:01 somera

If we can fix it, I think it's very possible. But I cannot reproduce this on my local machine. I'm using FF.

lunny avatar Jan 18 '24 12:01 lunny

I have same problem with FF 121.0.1.

somera avatar Jan 18 '24 12:01 somera

Same problem with Edge.

somera avatar Jan 21 '24 11:01 somera

If we can fix it, I think it's very possible. But I cannot reproduce this on my local machine. I'm using FF.

Any updates here? I can't be the only one with the problem.

I tested it on Windows and Linux.

somera avatar Jan 27 '24 16:01 somera

Same problem in 1.21.5

somera avatar Feb 01 '24 23:02 somera

I found the problem.

It's an Layer-8 problem!!!

After upgrade to 1.21.4 and 1.21.5 I forgot to compile the release cause I need the public folder for my Nginx proxy. After I did it now it work's. Now I updated my todo's for the next gitea updates -> checkout the release tag, compile it and copy the public folder to nginx proxy.

Mea culpa.

somera avatar Feb 04 '24 17:02 somera

Automatically locked because of our CONTRIBUTING guidelines

github-actions[bot] avatar Feb 28 '24 00:02 github-actions[bot]