gitea icon indicating copy to clipboard operation
gitea copied to clipboard

Published 20 hours ago • verified publisher icon go-gitea

Allow watching custom events

Open JakobDev opened this issue 1 year ago • 15 comments

Implements #21948

At the moment you can only watch all events if you watch a repo. With this PR you can now choose which event you want to watch. You can choose between Issues, Pull Requests and Releases. It's basically the same as GitHub does.

At the Moment there is no UI to configure this. It can only be configured through the API. But the Backend is fully working and ready to review.

To-Do:

  • [ ] Frontend
  • [x] Tests
  • [ ] Migration

JakobDev avatar Sep 01 '23 12:09 JakobDev

I have now added a Frontend. I tried to mimic the one of GitHub. It is currently really basic and looks ugly, but it works. Its is more a prof of concept than a final UI. If you click on "Custom" on GitHub, it will also open a new page where you can choose what you want to watch, but I don't know if this is possible with the Gitea UiI

grafik

@silverwind You have a loot more frontend skills. Maybe you could take a look at it?

JakobDev avatar Sep 04 '23 10:09 JakobDev

This change affects the subscriptions endpoint. I am waiting for the PR, then to adjust the #26797

CaiCandong avatar Sep 05 '23 04:09 CaiCandong

Which one will go first this pr or https://github.com/go-gitea/gitea/pull/26797 <-- this one.

puni9869 avatar Sep 05 '23 04:09 puni9869

Which one will go first this pr or #26797 <-- this one.

#26865 first, then I should do some adjusting in #26797. @JakobDev What's your opinion?

CaiCandong avatar Sep 05 '23 05:09 CaiCandong

What's your opinion?

Correct me if I'm wrong, but it looks like your PR is about wtaching Issues, but this PR is about watching Repos, so they don't touch the same codebase.

JakobDev avatar Sep 05 '23 10:09 JakobDev

Correct me if I'm wrong, but it looks like your PR is about wtaching Issues, but this PR is about watching Repos, so they don't touch the same codebase.

Yes, but the current logic is that watching the repository is the same as subscribing to the entire repository's issue. But I noticed you'll be modifying this logic, so maybe I should wait for you to finish it first.

CaiCandong avatar Sep 05 '23 10:09 CaiCandong

If you think this also affects your PR, you should wait. This PR is almost finished. The big missing part is a good UI.

JakobDev avatar Sep 05 '23 10:09 JakobDev

Can maybe take a look at ui in a few days.

silverwind avatar Sep 06 '23 23:09 silverwind

My thanks! I have experimented on my local machine, but I can't get it looking good. I have tried to do a second page for custom options like GitHub, but it's really hacky. The backend and tests are finished. the only missing thing is a god looking frontend.

JakobDev avatar Sep 07 '23 09:09 JakobDev

I give a try today.

puni9869 avatar Sep 07 '23 13:09 puni9869

@JakobDev I have started working on the UI, currently in the middle. Will share the draft Ui soon.

puni9869 avatar Oct 24 '23 08:10 puni9869

Could you resolved the conflicts and update this branch.

puni9869 avatar Oct 24 '23 08:10 puni9869

I have started working on the UI,

Thanks

Could you resolved the conflicts and update this branch.

Done

JakobDev avatar Oct 24 '23 08:10 JakobDev

@puni9869 Is there any news about your UI? Thx

BluePixel4k avatar Feb 01 '24 19:02 BluePixel4k

Hi, How is this going ? Thanks

KaKi87 avatar May 11 '24 15:05 KaKi87