gitea
gitea copied to clipboard
go-gitea
Add milestone labels
Is it necessary to display milestone's lables in issue view interface? It may made some confusion.
One more thing, there is a shared template for "label list", could the "milestone_new.tmpl" reuse the shared template?
And it looks strange to use <form class="ui comment (the comment) for a milestone form.
Please resolve all resolved conversations, so we know what's left to do.
@silverwind all updated according to comments, except: "SQL to delete" not added "label list" shared template not used, because it is a different UI component that looks like table
I still think both issue labels and milestone labels displayed in the issue sidebar are confusing.
I still think both issue labels and milestone labels displayed in the issue sidebar are confusing.
Hmm .... yup, so, let's first clarify the requirement before reviewing?
IMO the root question is: why milestones should have labels? If the labels are for mainly filtering purpose, does it make sense to attach labels to milestones?
Hmm I think if someone is really so heavily using milestones to needing labels on them, it's a somewhat valid use case and labels can exist in milestone lists, but I still would not litter the issue/pr view with these second set of labels, it's too confusing.
Milestone link alone should be sufficient for issue/pr view.
Update:
- used container.Set[T]
- deleted milestone labels from issue sidebar
- added milestone filtering by label
it looks strange to use
<form class="ui comment(thecomment) for a milestone form.
This is the requirement for label select dropdown to work. You can see that issue/new_form.tmpl also has the comment class.
There is a bug in the text color rendering on the milestone list, the text is white:
Color is correct on milestone edit page:
Also correct in the issue list:
How about remove milestone labels in issue page and keep milestone list/detail pages?
How about remove milestone labels in issue page and keep milestone list/detail pages?
They were removed in previous update
How about remove milestone labels in issue page and keep milestone list/detail pages?
They were removed in previous update
It's better to update the screenshots on the issue content.
Is it ready for review again? It helps if you comment after updates, because simple pushes to the branch don't trigger a GitHub notification.
@silverwind yes I replaced labels to RenderLabel and added deletion of MilestoneLabels when repo is deleted
Could we display labels on the milestone detail page.
I agree but we shouldn't bloat the scope of this PR too much. It's been waiting too long already. Let's get it into a mergable state and refine later.
Could we display labels on the milestone detail page.
I agree but we shouldn't bloat the scope of this PR too much. It's been waiting too long already. Let's get it into a mergable state and refine later.
I don't think so. Like issue labels will be displayed in issue list and issue detail page. Currently milestone labels just are displayed in milestone list. They should also be displayed in milestone detail page.
- labelExclusiveScopes taken out to a new function
- display labels on milestone detail page
I will update it only one more time, if there are any additional issues with this PR let me know or I am closing it next time.