delve icon indicating copy to clipboard operation
delve copied to clipboard

support linux-loong64 native debug

Open yelvens opened this issue 1 year ago • 13 comments

LoongArch is a new RISC ISA, which is independently designed by Loongson Technology.

LoongArch includes a reduced 32-bit version (LA32R), a standard 32-bit version (LA32S) and a 64-bit version (LA64), and loong64 is the 64-bit version of LoongArch.

LoongArch documentation: https://github.com/loongson/LoongArch-Documentation.git

Since version 1.19, golang upstream support for the LA architecture has been maintained.

yelvens avatar Mar 12 '24 09:03 yelvens

The arch project hasn't been integrated into the upstream yet, so I duplicated it to the vendor and submitted it.

yelvens avatar Mar 12 '24 09:03 yelvens

PS. also see test failures.

aarzilli avatar Mar 12 '24 11:03 aarzilli

@ihuang77 any updates on this based on @aarzilli feedback?

derekparker avatar Apr 19 '24 15:04 derekparker

Hi @aarzilli @derekparker

The x/arch has submitted a PR to support loong64, but it has not yet been merged into the upstream repository.

I can provide machines running CI at any time.

Thanks.

yelvens avatar Apr 23 '24 03:04 yelvens

That's cool, we'll have to wait for that PR to be merged for this.

aarzilli avatar Apr 23 '24 05:04 aarzilli

Hi @aarzilli @derekparker

The x/arch has submitted a PR to support loong64, but it has not yet been merged into the upstream repository.

I can provide machines running CI at any time.

Thanks.

Looks like this has merged. Are you available to pick this work back up?

derekparker avatar Oct 03 '24 21:10 derekparker

@ihuang77 any updates on this based on @aarzilli feedback?

Yes, the x/arch has been implemented and we are ready to update the Pr as soon as possible. We can also provide CI machines at any time.

abner-chenc avatar Oct 04 '24 14:10 abner-chenc

Looks like this has merged. Are you available to pick this work back up?

Hi @derekparker @derekparker The PR I submitted in x/arch has been merged. I just updated the PR I submitted here, and I would appreciate it if you could review the updated code. Thank you for your hard work.

yelvens avatar Oct 09 '24 06:10 yelvens

go get -u golang.org/x/arch@master --> go get -u golang.org/x/[email protected]

Thank you. I have completed that task and have created a new PR specifically for submitting the arch update.

yelvens avatar Oct 09 '24 07:10 yelvens

Hi @aarzilli @derekparker As I mentioned earlier:

I can provide machines running CI at any time.

The machines are always ready. If possible, could you kindly provide the runners configured as needed? Thank you.

yelvens avatar Oct 11 '24 08:10 yelvens

Hi @aarzilli @derekparker As I mentioned earlier:

I can provide machines running CI at any time.

The machines are always ready. If possible, could you kindly provide the runners configured as needed? Thank you.

You can download the agent from https://delve.teamcity.com/agents/overview (also note that there currently are test failures).

aarzilli avatar Oct 11 '24 12:10 aarzilli

Hi @aarzilli @derekparker As I mentioned earlier:

I can provide machines running CI at any time.

The machines are always ready. If possible, could you kindly provide the runners configured as needed? Thank you.

You can download the agent from https://delve.teamcity.com/agents/overview (also note that there currently are test failures). Hi, the loong64 machine and agent are ready, but before executing bin/agent.sh start, some configurations should be modified in conf/buildAgent.properties, such as what is the serverUrl value?

abner-chenc avatar Oct 25 '24 11:10 abner-chenc

Hi @aarzilli @derekparker As I mentioned earlier:

I can provide machines running CI at any time.

The machines are always ready. If possible, could you kindly provide the runners configured as needed? Thank you.

You can download the agent from https://delve.teamcity.com/agents/overview (also note that there currently are test failures). Hi, the loong64 machine and agent are ready, but before executing bin/agent.sh start, some configurations should be modified in conf/buildAgent.properties, such as what is the serverUrl value?

Yes, see: https://www.jetbrains.com/help/teamcity/configure-agent-installation.html I have never installed an agent myself so I can not provide any specific guidance there. Also, note the merge conflicts and test failures.

aarzilli avatar Oct 25 '24 11:10 aarzilli

Hi @aarzilli @derekparker As I mentioned earlier:

I can provide machines running CI at any time.

The machines are always ready. If possible, could you kindly provide the runners configured as needed? Thank you.

You can download the agent from https://delve.teamcity.com/agents/overview (also note that there currently are test failures). Hi, the loong64 machine and agent are ready, but before executing bin/agent.sh start, some configurations should be modified in conf/buildAgent.properties, such as what is the serverUrl value?

Yes, see: https://www.jetbrains.com/help/teamcity/configure-agent-installation.html I have never installed an agent myself so I can not provide any specific guidance there. Also, note the merge conflicts and test failures.

I read the instructions here, but there are no detailed steps. I still don't know how to deal with it. I configured serverUrl=https://delve.teamcity.com/app/dsl-plugins-repository and started the agent, but an error occurred.

abner-chenc avatar Oct 28 '24 10:10 abner-chenc

@aarzilli @derekparker @abner-chenc

I'm sorry that I haven't worked here for a long time because I've been working on other things recently. I modified the build and test failures today and pushed the code here. Please review the code when your time permits. Thank you.

yelvens avatar Nov 26 '24 08:11 yelvens

@aarzilli Can you please take another look at this patch? Thanks a lot.

yelvens avatar Dec 09 '24 10:12 yelvens

Hi, @aarzilli Can this Pr be merged? When I use delve on different machines to debug Go programs on loong64 machines, I need to download this Pr to the local machine and compile it separately each time. I think if this Pr can be merged, I will have a better experience when using delve.

Thanks

abner-chenc avatar Dec 20 '24 12:12 abner-chenc