delve icon indicating copy to clipboard operation
delve copied to clipboard

Published 20 hours ago • verified publisher icon go-delve

proc,service: change FindLocation to work with multiple targets

Open aarzilli opened this issue 2 years ago • 1 comments

Changes FindLocation to support multiple targets and adds an AddrPid member to api.Breakpoint so that clients can set breakpoints by address when multiple targets are connected (but at them moment this field is ignored).

Updates #1653 Updates #2551

aarzilli avatar Aug 12 '22 14:08 aarzilli

gotip failures are due to #54411

aarzilli avatar Aug 12 '22 15:08 aarzilli

Sorry for the delay, will review more fully tomorrow morning my time.

derekparker avatar Sep 20 '22 20:09 derekparker

No problem.

aarzilli avatar Sep 21 '22 08:09 aarzilli

Sorry for taking forever to review, even after the above comment. Caught a bug last week that put me down for a few days.

derekparker avatar Sep 26 '22 17:09 derekparker

It's ok, I've been trying to get a review for this for 4 months: https://reviews.llvm.org/D128504 🤣

aarzilli avatar Sep 27 '22 07:09 aarzilli