Improve the documentation of chi.Router

Open curio77 opened this issue 3 years ago • 4 comments

Make it clear(er) what the "fresh middleware stack" means and document some intrinsics/caveats.

Resolves go-chi/chi#712

Mar 18 '22 12:03 curio77

Just ran into this on the go doc today when implementing a router group.

Mar 22 '23 23:03 tyliggity

I was also misled by fresh middleware stack. I find phrasing proposed in this PR too long and excessive, simple change of fresh to copy seems more appropriate

Found this PR doing due diligence for opening my own. Sadly 1.5 years of ghosting this PR doesn't reinforce confidence in the project.

Oct 16 '23 23:10 TheRandomCharacter

@TheRandomCharacter I hesitated to review this PR as the new GoDoc comment felt very long to me. I agree that changing fresh to copy might just do the job? Mind submitting a PR, please?

Oct 17 '23 12:10 VojtechVitek

@VojtechVitek Submitted a new PR #862. Also conversion to *Mux in Group() looks superfluous to me. Made PR for that also (#863)

Oct 17 '23 16:10 TheRandomCharacter