go-archaius icon indicating copy to clipboard operation
go-archaius copied to clipboard

Published 20 hours ago • verified publisher icon go-chassis

Cache config value to optimize Get config API

Open x-xy-y opened this issue 2 years ago • 8 comments

读配置的过程， 前后要经过好多次锁，而且会受 source 实现影响。改为直接缓存当前的配置值，读取时从当前缓存读。

修改前：

go test -bench=^Benchmark -benchtime=5s
goos: darwin goarch: amd64 pkg: github.com/go-chassis/go-archaius/benchmark BenchmarkFileSource-8 5213296 1142 ns/op BenchmarkFileSourceParallelism-8 18202258 347 ns/op

修改后：

go test -bench=^Benchmark -benchtime=5s
goos: darwin goarch: amd64 pkg: github.com/go-chassis/go-archaius/benchmark BenchmarkFileSource-8 68292421 87.3 ns/op BenchmarkFileSourceParallelism-8 100000000 54.8 ns/op

x-xy-y avatar Dec 23 '21 11:12 x-xy-y

先把圈复杂度的检查去掉吧，这个工具肯定又出问题了 https://github.com/go-chassis/go-archaius/blob/2df34b14a90abeceb568a752a0ed37c645067ef9/.github/workflows/static_check.yml#L34

tianxiaoliang avatar Dec 25 '21 03:12 tianxiaoliang

先把圈复杂度的检查去掉吧，这个工具肯定又出问题了

https://github.com/go-chassis/go-archaius/blob/2df34b14a90abeceb568a752a0ed37c645067ef9/.github/workflows/static_check.yml#L34

得删掉这部分，门禁才能过

tianxiaoliang avatar Dec 29 '21 08:12 tianxiaoliang

上回提到事件更新行为一直都有不能保证最终一致的问题 我最近加了一个单元测试 consistencytest , 并修复了相关的问题 不过呢，有一个关联的 archaius.Delete 的行为有点奇怪，它目前的实现是 source 的配置不删除(有一些 source 甚至只给了个空实现)，在 mem source 会触发配置删除事件，然后原先的单元测试和我新加的 consistencytest 都会依赖它。我理解 archaius.Delete 存在的意义就是用于单元测试，所以我修改了 mem source 的 Delete 行为，让它删除自己的 map 里的配置，再触发通知，以保证 consistencytest 的行为正确（以及我的其他修改后的单元测试可以通过）。

在目前的 master 上，(加上 mem source 的 Delete 修改) 运行 consistencytest， 可以比较容易复现配置无法保证最终一致的问题.

在修改了 updateEvent 机制的 feature/cache-config-value 分支上, consistencytest 可以 pass

master 上的失败信息

--- FAIL: TestFinalConsistencyAfterConcurrentUpdateDelete (0.33s)
    consistency_test.go:73: test run 00000
    consistency_test.go:73: test run 00001
    consistency_test.go:73: test run 00002
    consistency_test.go:73: test run 00003
    consistency_test.go:73: test run 00004
    consistency_test.go:73: test run 00005
    consistency_test.go:73: test run 00006
    consistency_test.go:73: test run 00007
    consistency_test.go:73: test run 00008
    consistency_test.go:73: test run 00009
    consistency_test.go:73: test run 00010
    consistency_test.go:73: test run 00011
    consistency_test.go:73: test run 00012
    consistency_test.go:73: test run 00013
    consistency_test.go:73: test run 00014
    consistency_test.go:73: test run 00015
    consistency_test.go:73: test run 00016
    consistency_test.go:73: test run 00017
    consistency_test.go:73: test run 00018
    consistency_test.go:73: test run 00019
    consistency_test.go:73: test run 00020
    consistency_test.go:73: test run 00021
    consistency_test.go:73: test run 00022
    consistency_test.go:73: test run 00023
    consistency_test.go:73: test run 00024
    consistency_test.go:73: test run 00025
    consistency_test.go:73: test run 00026
    consistency_test.go:73: test run 00027
    consistency_test.go:73: test run 00028
    consistency_test.go:73: test run 00029
    consistency_test.go:73: test run 00030
    consistency_test.go:73: test run 00031
    consistency_test.go:73: test run 00032
    consistency_test.go:73: test run 00033
    consistency_test.go:73: test run 00034
    consistency_test.go:73: test run 00035
    consistency_test.go:73: test run 00036
    consistency_test.go:73: test run 00037
    consistency_test.go:73: test run 00038
    consistency_test.go:73: test run 00039
    consistency_test.go:73: test run 00040
    consistency_test.go:73: test run 00041
    consistency_test.go:73: test run 00042
    consistency_test.go:73: test run 00043
    consistency_test.go:73: test run 00044
    consistency_test.go:73: test run 00045
    consistency_test.go:73: test run 00046
    consistency_test.go:73: test run 00047
    consistency_test.go:73: test run 00048
    consistency_test.go:73: test run 00049
    consistency_test.go:73: test run 00050
    consistency_test.go:73: test run 00051
    consistency_test.go:73: test run 00052
    consistency_test.go:73: test run 00053
    consistency_test.go:73: test run 00054
    consistency_test.go:73: test run 00055
    consistency_test.go:73: test run 00056
    consistency_test.go:73: test run 00057
    consistency_test.go:73: test run 00058
    consistency_test.go:73: test run 00059
    consistency_test.go:73: test run 00060
    consistency_test.go:73: test run 00061
    consistency_test.go:73: test run 00062
    consistency_test.go:73: test run 00063
    consistency_test.go:73: test run 00064
    consistency_test.go:73: test run 00065
    consistency_test.go:73: test run 00066
    consistency_test.go:73: test run 00067
    consistency_test.go:73: test run 00068
    consistency_test.go:73: test run 00069
    consistency_test.go:73: test run 00070
    consistency_test.go:73: test run 00071
    consistency_test.go:73: test run 00072
    consistency_test.go:73: test run 00073
    consistency_test.go:73: test run 00074
    consistency_test.go:73: test run 00075
    consistency_test.go:73: test run 00076
    consistency_test.go:73: test run 00077
    consistency_test.go:73: test run 00078
    consistency_test.go:73: test run 00079
    consistency_test.go:73: test run 00080
    consistency_test.go:73: test run 00081
    consistency_test.go:73: test run 00082
    consistency_test.go:73: test run 00083
    consistency_test.go:73: test run 00084
    consistency_test.go:73: test run 00085
    consistency_test.go:73: test run 00086
    consistency_test.go:73: test run 00087
    consistency_test.go:73: test run 00088
    consistency_test.go:73: test run 00089
    consistency_test.go:73: test run 00090
    consistency_test.go:73: test run 00091
    consistency_test.go:73: test run 00092
    consistency_test.go:73: test run 00093
    consistency_test.go:73: test run 00094
    consistency_test.go:73: test run 00095
    consistency_test.go:73: test run 00096
    consistency_test.go:73: test run 00097
    consistency_test.go:73: test run 00098
    consistency_test.go:73: test run 00099
    consistency_test.go:73: test run 00100
    consistency_test.go:73: test run 00101
    consistency_test.go:73: test run 00102
    consistency_test.go:73: test run 00103
    consistency_test.go:73: test run 00104
    consistency_test.go:73: test run 00105
    consistency_test.go:73: test run 00106
    consistency_test.go:73: test run 00107
    consistency_test.go:73: test run 00108
    consistency_test.go:73: test run 00109
    consistency_test.go:73: test run 00110
    consistency_test.go:73: test run 00111
    consistency_test.go:73: test run 00112
    consistency_test.go:73: test run 00113
    consistency_test.go:73: test run 00114
    consistency_test.go:73: test run 00115
    consistency_test.go:73: test run 00116
    consistency_test.go:73: test run 00117
    consistency_test.go:73: test run 00118
    consistency_test.go:73: test run 00119
    consistency_test.go:73: test run 00120
    consistency_test.go:73: test run 00121
    consistency_test.go:73: test run 00122
    consistency_test.go:73: test run 00123
    consistency_test.go:73: test run 00124
    consistency_test.go:73: test run 00125
    consistency_test.go:73: test run 00126
    consistency_test.go:73: test run 00127
    consistency_test.go:73: test run 00128
    consistency_test.go:73: test run 00129
    consistency_test.go:73: test run 00130
    consistency_test.go:73: test run 00131
    consistency_test.go:73: test run 00132
    consistency_test.go:73: test run 00133
    consistency_test.go:73: test run 00134
    consistency_test.go:73: test run 00135
    consistency_test.go:73: test run 00136
    consistency_test.go:73: test run 00137
    consistency_test.go:73: test run 00138
    consistency_test.go:73: test run 00139
    consistency_test.go:73: test run 00140
    consistency_test.go:73: test run 00141
    consistency_test.go:73: test run 00142
    consistency_test.go:73: test run 00143
    consistency_test.go:73: test run 00144
    consistency_test.go:73: test run 00145
    consistency_test.go:73: test run 00146
    consistency_test.go:73: test run 00147
    consistency_test.go:73: test run 00148
    consistency_test.go:73: test run 00149
    consistency_test.go:73: test run 00150
    consistency_test.go:73: test run 00151
    consistency_test.go:73: test run 00152
    consistency_test.go:73: test run 00153
    consistency_test.go:73: test run 00154
    consistency_test.go:73: test run 00155
    consistency_test.go:73: test run 00156
    consistency_test.go:70:
        	Error Trace:	consistency_test.go:70
        	            				consistency_test.go:74
        	Error:      	Not equal:
        	            	expected: 3
        	            	actual  : 9
        	Test:       	TestFinalConsistencyAfterConcurrentUpdateDelete
FAIL
exit status 1
FAIL	github.com/go-chassis/go-archaius/consistencytest	1.878s

x-xy-y avatar Feb 11 '22 11:02 x-xy-y

cyclo检查失败了，把这个检查步骤干掉吧

tianxiaoliang avatar Feb 13 '22 12:02 tianxiaoliang

cyclo检查失败了，把这个检查步骤干掉吧

我删掉了 cyclo , 再看看？

x-xy-y avatar Feb 21 '22 07:02 x-xy-y

可以推送到新的banch vx.x.x.beta

tianxiaoliang avatar Feb 22 '22 12:02 tianxiaoliang

可以推送到新的banch vx.x.x.beta

我应该是没有权限直接推送到这个库的。能做的是创建 Pull Request . 但也不存在一个 vx.x.x.beta 的分支给我选择。是不是你要先建一下这个分支

image

x-xy-y avatar Feb 23 '22 12:02 x-xy-y

https://github.com/go-chassis/go-archaius/tree/v1.6.0.beta done

tianxiaoliang avatar Feb 24 '22 01:02 tianxiaoliang