lego icon indicating copy to clipboard operation
lego copied to clipboard

Add DNS provider for RU Center

Open AntonDzyk opened this issue 1 year ago • 6 comments

AntonDzyk avatar Apr 12 '23 11:04 AntonDzyk

Hello, in order for a PR adding a DNS provider to be accepted, you have to:

  • [ ] add a description to your PR
  • [ ] be able to maintain this provider
  • [x] have a homogeneous design with the other providers
  • [x] add tests (units)
make test
  • [x] add tests ("live") https://github.com/go-acme/lego/blob/c938de68f262c057542d44bcb67ef961cefcc60e/providers/dns/cloudflare/cloudflare_test.go#L125-L151
make test
make generate-dns
  • [ ] be able to do: (and put the output of this command to a comment in your PR)
rm -rf .lego

./lego -m [email protected] --dns YOUR_PROVIDER_NAME -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run

Note the wildcard domain is important.

make checks
  • [x] do go mod tidy

ldez avatar Apr 12 '23 12:04 ldez

Your PR was far away from the design of the other implementations, so I rewrite it and add tests on the client.

You can check my previous comment to know what are the next requirements.

ldez avatar Apr 12 '23 22:04 ldez

ping @AntonDzyk

ldez avatar Apr 13 '23 16:04 ldez

@AntonDzyk can you provide the missing information? https://github.com/go-acme/lego/pull/1892#issuecomment-1505154811

ldez avatar Apr 22 '23 16:04 ldez

ping @AntonDzyk

ldez avatar May 15 '23 09:05 ldez

I'm still waiting for feedback @AntonDzyk.


If there is a user that wants to test this PR, you are welcome.

ldez avatar Jun 07 '23 12:06 ldez