lego
lego copied to clipboard
Add DNS provider for RU Center
Hello, in order for a PR adding a DNS provider to be accepted, you have to:
- [ ] add a description to your PR
- [ ] be able to maintain this provider
- [x] have a homogeneous design with the other providers
- [x] add tests (units)
make test
- [x] add tests ("live") https://github.com/go-acme/lego/blob/c938de68f262c057542d44bcb67ef961cefcc60e/providers/dns/cloudflare/cloudflare_test.go#L125-L151
make test
- [x] add a provider descriptor
- [x] generate CLI help, documentation, and readme.
make generate-dns
- [ ] be able to do: (and put the output of this command to a comment in your PR)
rm -rf .lego
./lego -m [email protected] --dns YOUR_PROVIDER_NAME -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
Note the wildcard domain is important.
- [x] pass the linter (golangci-lint must be installed):
make checks
- [x] do
go mod tidy
Your PR was far away from the design of the other implementations, so I rewrite it and add tests on the client.
You can check my previous comment to know what are the next requirements.
ping @AntonDzyk
@AntonDzyk can you provide the missing information? https://github.com/go-acme/lego/pull/1892#issuecomment-1505154811
ping @AntonDzyk
I'm still waiting for feedback @AntonDzyk.
If there is a user that wants to test this PR, you are welcome.